pramodbiligiri commented on code in PR #6665: URL: https://github.com/apache/hudi/pull/6665#discussion_r979596301
########## hudi-utilities/src/main/java/org/apache/hudi/utilities/sources/helpers/gcs/PubsubMessagesFetcher.java: ########## @@ -0,0 +1,118 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hudi.utilities.sources.helpers.gcs; + +import com.google.cloud.pubsub.v1.stub.GrpcSubscriberStub; +import com.google.cloud.pubsub.v1.stub.SubscriberStub; +import com.google.cloud.pubsub.v1.stub.SubscriberStubSettings; +import com.google.pubsub.v1.AcknowledgeRequest; +import com.google.pubsub.v1.ProjectSubscriptionName; +import com.google.pubsub.v1.PullRequest; +import com.google.pubsub.v1.PullResponse; +import com.google.pubsub.v1.ReceivedMessage; +import org.apache.hudi.exception.HoodieException; +import org.apache.log4j.LogManager; +import org.apache.log4j.Logger; +import static com.google.cloud.pubsub.v1.stub.GrpcSubscriberStub.create; +import java.io.IOException; +import java.util.List; +import static org.apache.hudi.utilities.sources.helpers.gcs.GcsIngestionConfig.DEFAULT_MAX_INBOUND_MESSAGE_SIZE; + +/** + * Fetch messages from a specified Google Cloud Pubsub subscription. + */ +public class PubsubMessagesFetcher { + + private final String googleProjectId; + private final String pubsubSubscriptionId; + + private final int batchSize; + private final SubscriberStubSettings subscriberStubSettings; + + private final int maxInboundMessageSize; + + private static final Logger LOG = LogManager.getLogger(PubsubMessagesFetcher.class); + + public PubsubMessagesFetcher(String googleProjectId, String pubsubSubscriptionId, int batchSize) { + this.googleProjectId = googleProjectId; + this.pubsubSubscriptionId = pubsubSubscriptionId; + this.batchSize = batchSize; + + maxInboundMessageSize = DEFAULT_MAX_INBOUND_MESSAGE_SIZE; + + try { + /** For details of timeout and retry configs, + * see {@link com.google.cloud.pubsub.v1.stub.SubscriberStubSettings#initDefaults()}, + * and the static code block in SubscriberStubSettings */ + subscriberStubSettings = + SubscriberStubSettings.newBuilder() + .setTransportChannelProvider( + SubscriberStubSettings.defaultGrpcTransportProviderBuilder() + .setMaxInboundMessageSize(maxInboundMessageSize) + .build()) + .build(); + } catch (IOException e) { + throw new HoodieException("Error creating subscriber stub settings", e); + } + } + + public List<ReceivedMessage> fetchMessages() { Review Comment: Pubsub does send delete events, but this code currently ignores all events except the one indicating that a new file has been uploaded for the first time. More details here: https://docs.google.com/document/d/1VfvtdvhXw6oEHPgZ_4Be2rkPxIzE0kBCNUiVDsXnSAA/edit#heading=h.fy5gfxcdgtg1 @rmahindra123 for visibility regarding this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
