pramodbiligiri commented on code in PR #6665: URL: https://github.com/apache/hudi/pull/6665#discussion_r980753685
########## hudi-utilities/src/main/java/org/apache/hudi/utilities/sources/helpers/gcs/MessageValidity.java: ########## @@ -0,0 +1,48 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hudi.utilities.sources.helpers.gcs; + +/** + * A valid message that should be processed, or a message to skip (with an optional reason to skip it). + */ +public enum MessageValidity { + + // A valid message that should be processed + DO_PROCESS("Valid message"), + + // A message that should be skipped + DO_SKIP("Reason to skip not initialized"); + + // Note: Java enum behavior implies that all SKIP instances are treated the same + // during reference equality comparison, even if the values of reasonToSkip might vary. + private String reasonToSkip; + + MessageValidity(String reasonToSkip) { + this.reasonToSkip = reasonToSkip; + } + + public MessageValidity setReasonToSkip(String reasonToSkip) { + this.reasonToSkip = reasonToSkip; Review Comment: Great catch. It is not thread safe. Currently it is not run in multi-threaded code so it works fine. Let me think about this and see how to resolve this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
