codope commented on code in PR #6498:
URL: https://github.com/apache/hudi/pull/6498#discussion_r981114413
##########
hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/table/functional/TestCleanPlanExecutor.java:
##########
@@ -263,11 +264,9 @@ public void testKeepLatestCommits(
assertTrue(testTable.baseFileExists(p0, "00000000000007", file4P0C3));
}
- /**
- * Test Hudi COW Table Cleaner - Keep the latest file versions policy.
- */
- @Test
- public void testKeepLatestFileVersions() throws Exception {
+ @ParameterizedTest
+ @ValueSource(Boolean.class)
+ public void testKeepLatestFileVersions(boolean ) throws Exception {
Review Comment:
missing an argument here? did you intend to test with and without
incremental mode enabled?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
