wzx140 commented on code in PR #6745:
URL: https://github.com/apache/hudi/pull/6745#discussion_r981330556
##########
hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/commmon/model/HoodieSparkRecord.java:
##########
@@ -47,42 +50,49 @@
import java.util.Properties;
import static
org.apache.hudi.common.table.HoodieTableConfig.POPULATE_META_FIELDS;
+import static
org.apache.hudi.util.HoodieSparkRecordUtils.getNullableValAsString;
+import static org.apache.hudi.util.HoodieSparkRecordUtils.getValue;
import static org.apache.spark.sql.types.DataTypes.BooleanType;
import static org.apache.spark.sql.types.DataTypes.StringType;
/**
* Spark Engine-specific Implementations of `HoodieRecord`.
*/
+@DefaultSerializer(HoodieSparkRecordSerializer.class)
public class HoodieSparkRecord extends HoodieRecord<InternalRow> {
Review Comment:
It doesn't fail when someone start using it filling it w/
GenericInternalRow. HoodieSparkRecordSerializer use FiledSerializer to deal
with HoodieSparkRecord(without schema). It can deal with all subclasses of
internalRow.
We may have ColumnarRow later. So UnsafeProjection is not neccessary?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
