xushiyan commented on code in PR #6753:
URL: https://github.com/apache/hudi/pull/6753#discussion_r982256620
##########
hudi-utilities/src/main/java/org/apache/hudi/utilities/deltastreamer/HoodieDeltaStreamer.java:
##########
@@ -651,6 +656,9 @@ public DeltaSyncService(Config cfg, JavaSparkContext jssc,
FileSystem fs, Config
+ cfg.baseFileFormat);
cfg.baseFileFormat = baseFileFormat;
this.cfg.baseFileFormat = baseFileFormat;
+ HashMap<String,String> propsToValidate = new HashMap<>();
Review Comment:
should declare Map instead of concrete impl. class.
##########
pom.xml:
##########
@@ -145,6 +145,7 @@
<flink.clients.artifactId>flink-clients</flink.clients.artifactId>
<flink.connector.kafka.artifactId>flink-connector-kafka</flink.connector.kafka.artifactId>
<flink.hadoop.compatibility.artifactId>flink-hadoop-compatibility_2.12</flink.hadoop.compatibility.artifactId>
+ <rocksdbjni.version>5.17.2</rocksdbjni.version>
Review Comment:
although no risk, we should avoid having irrelevant change mixed in a patch
that meant for other issue.
##########
hudi-utilities/src/main/java/org/apache/hudi/utilities/deltastreamer/HoodieDeltaStreamer.java:
##########
@@ -651,6 +656,9 @@ public DeltaSyncService(Config cfg, JavaSparkContext jssc,
FileSystem fs, Config
+ cfg.baseFileFormat);
cfg.baseFileFormat = baseFileFormat;
this.cfg.baseFileFormat = baseFileFormat;
+ HashMap<String,String> propsToValidate = new HashMap<>();
+ properties.get().forEach((k,v) ->
propsToValidate.put(k.toString(),v.toString()));
+ HoodieWriterUtils.validateTableConfig(this.sparkSession,
JavaConverters.mapAsScalaMapConverter(propsToValidate).asScala().toMap(Predef.conforms()),
meta.getTableConfig());
Review Comment:
could have used
`org.apache.hudi.HoodieConversionUtils#mapAsScalaImmutableMap` to reduce code
verbosity.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
