satishkotha opened a new pull request #1540: URL: https://github.com/apache/incubator-hudi/pull/1540
## What is the purpose of the pull request Variable declared here [1] masks protected statuses variable. So although hoodie writes data, will not include WriteStatus in the completed section. This can cause duplicates being written [1] https://github.com/apache/incubator-hudi/blob/master/hudi-client/src/main/java/org/apache/hudi/execution/MergeOnReadLazyInsertIterable.java#L53 ## Brief change log - Delete MergeOnReadLazyInsertIterable because it is exact same as COW except for the type of handle created (HoodieCreateHandle vs HoodieAppendHandle) - Added new 'HandleCreator' classes and reuse code in COWLazyInsertIterable Let me know if you have any other suggestions to improve this code. This refactoring also helps me with implementation of 'insert overwrite' features. ## Verify this pull request This pull request is already covered by existing tests in hudi-client ## Committer checklist - [ ] Has a corresponding JIRA in PR title & commit - [ ] Commit message is descriptive of the change - [ ] CI is green - [ ] Necessary doc changes done or have another open PR - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
