codope commented on code in PR #6741:
URL: https://github.com/apache/hudi/pull/6741#discussion_r983062641
##########
hudi-hadoop-mr/src/main/java/org/apache/hudi/hadoop/realtime/AbstractRealtimeRecordReader.java:
##########
@@ -95,7 +97,7 @@ private boolean usesCustomPayload(HoodieTableMetaClient
metaClient) {
private void prepareHiveAvroSerializer() {
try {
- List<String> hiveInternalColumns = Arrays.asList(new String[]
{"BLOCK__OFFSET__INSIDE__FILE", "INPUT__FILE__NAME", "ROW__ID"});
+ Set<String> hiveInternalColumns = new HashSet(Arrays.asList(new String[]
{"BLOCK__OFFSET__INSIDE__FILE", "INPUT__FILE__NAME", "ROW__ID"}));
Review Comment:
I see there are more internal columns
https://cwiki.apache.org/confluence/display/hive/languagemanual+virtualcolumns
Also, this could change per Hive version (though not very frequently). How
do we plan to maintain it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
