codope commented on code in PR #6817:
URL: https://github.com/apache/hudi/pull/6817#discussion_r983165496
##########
hudi-utilities/src/main/java/org/apache/hudi/utilities/sources/RowSource.java:
##########
@@ -41,6 +41,9 @@ public RowSource(TypedProperties props, JavaSparkContext
sparkContext, SparkSess
@Override
protected final InputBatch<Dataset<Row>> fetchNewData(Option<String>
lastCkptStr, long sourceLimit) {
Pair<Option<Dataset<Row>>, String> res = fetchNextBatch(lastCkptStr,
sourceLimit);
+ if (overriddenSchemaProvider != null) {
+ return new InputBatch<>(res.getKey(), res.getValue(),
overriddenSchemaProvider);
+ }
Review Comment:
That's actually a valid point. I wrote a unit test with evolving schema.
But, it passes even without this change. I think we can hold off landing this
PR. Let me investigate more.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
