nsivabalan opened a new pull request, #6836:
URL: https://github.com/apache/hudi/pull/6836
### Change Logs
When metadata table is just getting initialized, but first commit is not yet
fully complete, reading from metadata table could fail w/ below stacktrace.
Call trace that could result in this.
```
BaseHoodieTableFileIndex.doRefresh() // metadata Config will have metadata
enabled if user enables for the query session. lets assume user enabled while
the metadata table is being built out.
{
HoodieTableMetadata newTableMetadata =
HoodieTableMetadata.create(engineContext, metadataConfig, ....);
HoodieTableMetadata.create eventually will call constructor
of HoodieBackedTableMetadata()
within which we call initIfNeeded()
within initIfNeeded {
we disable metadata only if
table itself is not found. if not, metadata is still enabled.
}
.
-> loadPartitionPathFiles
}
loadPartitionPathFiles {
...
getAllFilesInPartitionsUnchecked()
}
getAllFilesInPartitionsUnchecked {
tableMetadata.getAllFilesInPartitions(list of interested partitions)
}
getAllFilesInPartitions{
BaseTableMetadata.fetchAllFilesInPartitionPaths...
}
BaseTableMetadata.fetchAllFilesInPartitionPaths{
..
getRecordsByKeys(...)
}
HoodieBackedTableMetadata.getRecordsByKeys{
getPartitionFileSliceToKeysMapping()
}
getPartitionFileSliceToKeysMapping{
List<FileSlice> latestFileSlices =
HoodieTableMetadataUtil.getPartitionLatestMergedFileSlices(metadataMetaClient,
partitionName);
}
HoodieTableMetadataUtil.getPartitionLatestMergedFileSlices {
HoodieTableFileSystemView fsView =
fileSystemView.orElse(getFileSystemView(metaClient));
Stream<FileSlice> fileSliceStream;
if (mergeFileSlices) { // this is true for this call graph.
if
(metaClient.getActiveTimeline().filterCompletedInstants().lastInstant().isPresent())
{
fileSliceStream = fsView.getLatestMergedFileSlicesBeforeOrOn(
partition,
metaClient.getActiveTimeline().filterCompletedInstants().**lastInstant().get()**.getTimestamp());
}
}
```
There is no lastInstant as the Metadata table is still being initialized.
### Impact
_Describe any public API or user-facing feature change or any performance
impact._
**Risk level: none | low | medium | high**
_Choose one. If medium or high, explain what verification was done to
mitigate the risks._
### Documentation Update
_Describe any necessary documentation update if there is any new feature,
config, or user-facing change_
- _The config description must be updated if new configs are added or the
default value of the configs are changed_
- _Any new feature or user-facing change requires updating the Hudi website.
Please create a Jira ticket, attach the
ticket number here and follow the
[instruction](https://hudi.apache.org/contribute/developer-setup#website) to
make
changes to the website._
### Contributor's checklist
- [ ] Read through [contributor's
guide](https://hudi.apache.org/contribute/how-to-contribute)
- [ ] Change Logs and Impact were stated clearly
- [ ] Adequate tests were added if applicable
- [ ] CI passed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
