felixYyu commented on code in PR #5064: URL: https://github.com/apache/hudi/pull/5064#discussion_r984223291
########## hudi-metaserver/src/main/thrift/hudi-metaserver.thrift: ########## @@ -0,0 +1,106 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + + namespace java org.apache.hudi.metaserver.thrift + + // table related + struct Table { + 1: string tableName, + 2: string dbName, + 3: string owner, + 4: i32 createTime, + 5: string location, + 6: string tableType, + 7: list<FieldSchema> partitionKeys, + 8: map<string, string> parameters + } + + struct FieldSchema { + 1: string name, + 2: string type, + 3: string comments + } + +// timeline related +// align with actions defined in HoodieTimeline +enum TAction { + COMMIT = 1, + DELTACOMMIT = 2, + CLEAN = 3, + ROLLBACK = 4, + SAVEPOINT = 5, + REPLACECOMMIT = 6, + COMPACTION = 7, + RESTORE = 8 +} + +// align with states defined in HoodieInstant +enum TState { + REQUESTED = 1, + INFLIGHT = 2, + COMPLETED = 3, + INVALID = 4 +} + +struct THoodieInstant { + 1: string timestamp, + 2: TAction action, + 3: TState state +} + +struct HoodieInstantChangeResult { + 1: bool success, + 2: optional THoodieInstant instant, + 4: optional string msg +} + +exception MetaStoreException { + 1: string message +} + +exception MetaException { + 1: string message +} + +exception NoSuchObjectException { + 1: string message +} + +exception AlreadyExistException { + 1: string message +} + +service ThriftHoodieMetaServer { + // table related + void create_database(1:string db) Review Comment: The function name should follow hump expression, other too. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
