zhangyue19921010 commented on PR #5416: URL: https://github.com/apache/hudi/pull/5416#issuecomment-1272290024
> Do we have tests for DistruptorProducers? I found tests only for DistruptorExecutor and DistruptorMessageQueue. > > Also, do we have tests to test out single producer and multiple producers? and can you summarize what kind of error cases have been tested. 1 producer thread crashing while others are still continuing to produce, memory too low to hold all produced records, but still no records should be dropped, etc. Hi @nsivabalan Thanks a lot for reminding. Add more tests here including: 1. `TestBoundedInMemoryExecutorInSpark#testExecutor` ==> test common disruptor executor ingestion 2. `TestBoundedInMemoryExecutorInSpark#testInterruptExecutor` ==> test disruptor executor ingestion with interrupt 3. `TestDisruptorMessageQueue#testRecordReading` ==> test common single producer and single consumer reading 4. `TestDisruptorMessageQueue#testCompositeProducerRecordReading` ==> test multi-producers and single consumer 5. `TestDisruptorMessageQueue#testException` ==> test multi-producers which one producer thread crashing while others are still continuing to produce. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
