codope commented on code in PR #6898:
URL: https://github.com/apache/hudi/pull/6898#discussion_r992212503
##########
packaging/hudi-spark-bundle/pom.xml:
##########
@@ -95,6 +95,7 @@
<include>org.apache.httpcomponents:fluent-hc</include>
<include>org.antlr:stringtemplate</include>
<include>org.apache.parquet:parquet-avro</include>
+ <include>org.apache.avro:avro</include>
Review Comment:
Can you also shade Avro in other remaining bundles?
##########
packaging/hudi-spark-bundle/pom.xml:
##########
@@ -294,6 +295,10 @@
<shadedPattern>org.apache.hudi.org.apache.hadoop.metrics2.util.MetricSampleQuantiles
</shadedPattern>
</relocation>
+ <relocation>
Review Comment:
If it is being shaded in spark bundle, then please ensure Avro is relocated
in every other bundle, e.g. Hudi-hive-sync-bundle otherwise the two bundles
(one with shaded Avro and another with unshaded Avro) will run into conflict.
@nsivabalan Do you see any issues with relocating Avro in
hudi-hive-sync-bundle?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
