wzx140 commented on code in PR #6745:
URL: https://github.com/apache/hudi/pull/6745#discussion_r992562078
##########
hudi-common/src/main/java/org/apache/hudi/common/model/HoodieAvroRecord.java:
##########
@@ -170,8 +185,8 @@ public Option<Map<String, String>> getMetadata() {
}
@Override
- public Option<HoodieAvroIndexedRecord> toIndexedRecord(Schema schema,
Properties props) throws IOException {
- Option<IndexedRecord> avroData = getData().getInsertValue(schema, props);
+ public Option<HoodieAvroIndexedRecord> toIndexedRecord(Schema recordSchema,
Properties props) throws IOException {
Review Comment:
I think Option should wrapper outside. In HoodieAvroFileReader, we use
`HoodieRecord<IndexedRecord>`. And `HoodieRecord<Option<IndexedRecord>>` looks
strange. It is very different from the other two `HoodieRecord<InternalRow>`
and `HoodieRecord<HoodieAvroPayload>`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
