XuQianJin-Stars commented on code in PR #6284:
URL: https://github.com/apache/hudi/pull/6284#discussion_r994232758


##########
hudi-common/src/main/java/org/apache/hudi/common/util/FileIOUtils.java:
##########
@@ -204,4 +204,40 @@ public static Option<byte[]> readDataFromPath(FileSystem 
fileSystem, org.apache.
   public static Option<byte[]> readDataFromPath(FileSystem fileSystem, 
org.apache.hadoop.fs.Path detailPath) {
     return readDataFromPath(fileSystem, detailPath, false);
   }
+
+  /**
+   * Return the configured local directories where hudi can write files. This
+   * method does not create any directories on its own, it only encapsulates 
the
+   * logic of locating the local directories according to deployment mode.
+   */
+  public static String[] getConfiguredLocalDirs() {
+    if (isRunningInYarnContainer()) {
+      // If we are in yarn mode, systems can have different disk layouts so we 
must set it

Review Comment:
   > Thanks, should we take the write config as higher priority then ? If user 
configured it explicitly.
   
   It may be necessary to remove the default value
   ```
     public static final ConfigProperty<String> SPILLABLE_MAP_BASE_PATH = 
ConfigProperty
         .key("hoodie.memory.spillable.map.path")
         .defaultValue("/tmp/")
         .withDocumentation("Default file path prefix for spillable map");
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to