TisonKun opened a new pull request #1557:
URL: https://github.com/apache/incubator-hudi/pull/1557
## What is the purpose of the pull request
So far, the return type of HoodieRecordPayload#combineAndGetUpdateValue &
HoodieRecordPayload#getInsertValue is effectively Option<GenericRecord>.
Instead of doing unchecked cast at
org/apache/hudi/hadoop/realtime/RealtimeCompactedRecordReader.java:88
I propose we use Option<GenericRecord> as the return type of these two
method, which replaces current Option<IndexedRecord>.
FYI, I encounter this ticket when trying to get rid of self type parameter
in HoodieRecordPayload and found that it is a bit awkward if we don't take a
self type while doing this casting. Fortunately it is the fact that we can
directly concrete it.
cc @vinothchandar @leesf
## Verify this pull request
This pull request is code refactor should be covered by existing tests.
## Committer checklist
- [x] Has a corresponding JIRA in PR title & commit
- [x] Commit message is descriptive of the change
- [ ] CI is green
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
