xushiyan commented on code in PR #6946:
URL: https://github.com/apache/hudi/pull/6946#discussion_r996605827
##########
hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/index/hbase/SparkHoodieHBaseIndex.java:
##########
@@ -145,22 +154,22 @@ public HBaseIndexQPSResourceAllocator
createQPSResourceAllocator(HoodieWriteConf
private Connection getHBaseConnection() {
Configuration hbaseConfig = HBaseConfiguration.create();
String quorum = config.getHbaseZkQuorum();
- hbaseConfig.set("hbase.zookeeper.quorum", quorum);
+ hbaseConfig.set(ZOOKEEPER_QUORUM, quorum);
String zkZnodeParent = config.getHBaseZkZnodeParent();
if (zkZnodeParent != null) {
- hbaseConfig.set("zookeeper.znode.parent", zkZnodeParent);
+ hbaseConfig.set(ZOOKEEPER_ZNODE_PARENT, zkZnodeParent);
}
String port = String.valueOf(config.getHbaseZkPort());
- hbaseConfig.set("hbase.zookeeper.property.clientPort", port);
+ hbaseConfig.set(CLIENT_ZOOKEEPER_CLIENT_PORT, port);
Review Comment:
this constant resolves to `hbase.client.zookeeper.property.clientPort`. can
you confirm if it's fully compatible across different hbase versions? could you
pls also global search (e.g. `hbase.zookeeper.property.clientPort` ) and ensure
nothing breaks?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
