pratyakshsharma commented on pull request #1433: URL: https://github.com/apache/incubator-hudi/pull/1433#issuecomment-618979314
@vinothchandar Have tried to address the comments, please have a look again. Also looking at the Codecov report, I feel there is a need to add test cases for all key generators for which we do not have right now like SimpleKeyGenerator, ComplexKeyGenerator etc. Should I include that in this PR or should I go for a separate PR. Please suggest. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
