This is an automated email from the ASF dual-hosted git repository.
xushiyan pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/hudi.git
The following commit(s) were added to refs/heads/master by this push:
new cd679646e8 [HUDI-3900] Closing resources in TestHoodieLogRecord (#6995)
cd679646e8 is described below
commit cd679646e87a588469e473413f9bf3ce32b9d69e
Author: Sivabalan Narayanan <[email protected]>
AuthorDate: Tue Oct 18 20:49:59 2022 -0700
[HUDI-3900] Closing resources in TestHoodieLogRecord (#6995)
---
.../common/functional/TestHoodieLogFormat.java | 23 ++++++++++++++++++++--
1 file changed, 21 insertions(+), 2 deletions(-)
diff --git
a/hudi-common/src/test/java/org/apache/hudi/common/functional/TestHoodieLogFormat.java
b/hudi-common/src/test/java/org/apache/hudi/common/functional/TestHoodieLogFormat.java
index eae96755ab..1651574ad0 100755
---
a/hudi-common/src/test/java/org/apache/hudi/common/functional/TestHoodieLogFormat.java
+++
b/hudi-common/src/test/java/org/apache/hudi/common/functional/TestHoodieLogFormat.java
@@ -155,6 +155,7 @@ public class TestHoodieLogFormat extends
HoodieCommonTestHarness {
assertEquals(0, writer.getCurrentSize(), "Just created this log, size
should be 0");
assertTrue(writer.getLogFile().getFileName().startsWith("."), "Check all
log files should start with a .");
assertEquals(1, writer.getLogFile().getLogVersion(), "Version should be 1
for new log created");
+ writer.close();
}
@ParameterizedTest
@@ -698,7 +699,7 @@ public class TestHoodieLogFormat extends
HoodieCommonTestHarness {
assertEquals(scannedRecords.size(),
allRecords.stream().mapToLong(Collection::size).sum(),
"Scanner records count should be the same as appended records");
-
+ scanner.close();
}
@Test
@@ -933,6 +934,7 @@ public class TestHoodieLogFormat extends
HoodieCommonTestHarness {
copyOfRecords1.stream().map(s -> ((GenericRecord)
s).get(HoodieRecord.RECORD_KEY_METADATA_FIELD).toString())
.collect(Collectors.toSet());
assertEquals(originalKeys, readKeys, "CompositeAvroLogReader should return
200 records from 2 versions");
+ scanner.close();
}
@ParameterizedTest
@@ -1017,6 +1019,7 @@ public class TestHoodieLogFormat extends
HoodieCommonTestHarness {
copyOfRecords1.stream().map(s -> ((GenericRecord)
s).get(HoodieRecord.RECORD_KEY_METADATA_FIELD).toString())
.collect(Collectors.toSet());
assertEquals(originalKeys, readKeys, "CompositeAvroLogReader should return
200 records from 2 versions");
+ scanner.close();
}
@ParameterizedTest
@@ -1106,6 +1109,7 @@ public class TestHoodieLogFormat extends
HoodieCommonTestHarness {
copyOfRecords1.stream().map(s -> ((GenericRecord)
s).get(HoodieRecord.RECORD_KEY_METADATA_FIELD).toString())
.collect(Collectors.toSet());
assertEquals(originalKeys, readKeys, "CompositeAvroLogReader should return
200 records from 2 versions");
+ scanner.close();
}
@ParameterizedTest
@@ -1209,6 +1213,7 @@ public class TestHoodieLogFormat extends
HoodieCommonTestHarness {
FileCreateUtils.deleteDeltaCommit(basePath, "101", fs);
readKeys.clear();
+ scanner.close();
scanner = HoodieMergedLogRecordScanner.newBuilder()
.withFileSystem(fs)
.withBasePath(basePath)
@@ -1243,6 +1248,8 @@ public class TestHoodieLogFormat extends
HoodieCommonTestHarness {
Collections.sort(firstBlockRecords);
Collections.sort(readKeys);
assertEquals(firstBlockRecords, readKeys, "CompositeAvroLogReader should
return 150 records from 2 versions");
+ writer.close();
+ scanner.close();
}
@ParameterizedTest
@@ -1360,6 +1367,8 @@ public class TestHoodieLogFormat extends
HoodieCommonTestHarness {
Collections.sort(originalKeys);
Collections.sort(readKeys);
assertEquals(originalKeys, readKeys, "HoodieMergedLogRecordScanner should
return 180 records from 4 versions");
+ writer.close();
+ scanner.close();
}
@ParameterizedTest
@@ -1447,6 +1456,8 @@ public class TestHoodieLogFormat extends
HoodieCommonTestHarness {
scanner.forEach(s -> readKeys.add(s.getKey().getRecordKey()));
assertEquals(0, readKeys.size(), "Stream collect should return all 0
records");
FileCreateUtils.deleteDeltaCommit(basePath, "100", fs);
+ writer.close();
+ scanner.close();
}
@ParameterizedTest
@@ -1513,6 +1524,8 @@ public class TestHoodieLogFormat extends
HoodieCommonTestHarness {
.build();
assertEquals(0, scanner.getTotalLogRecords(), "We would read 0 records");
FileCreateUtils.deleteDeltaCommit(basePath, "100", fs);
+ writer.close();
+ scanner.close();
}
@ParameterizedTest
@@ -1568,6 +1581,8 @@ public class TestHoodieLogFormat extends
HoodieCommonTestHarness {
final List<String> readKeys = new ArrayList<>(100);
scanner.forEach(s -> readKeys.add(s.getKey().getRecordKey()));
assertEquals(100, readKeys.size(), "Stream collect should return all 150
records");
+ writer.close();
+ scanner.close();
}
@ParameterizedTest
@@ -1637,6 +1652,8 @@ public class TestHoodieLogFormat extends
HoodieCommonTestHarness {
.withUseScanV2(useScanv2)
.build();
assertEquals(0, scanner.getTotalLogRecords(), "We would read 0 records");
+ writer.close();
+ scanner.close();
}
@ParameterizedTest
@@ -1746,6 +1763,7 @@ public class TestHoodieLogFormat extends
HoodieCommonTestHarness {
.build();
assertEquals(0, scanner.getTotalLogRecords(), "We would read 0 records");
FileCreateUtils.deleteDeltaCommit(basePath, "100", fs);
+ scanner.close();
}
@ParameterizedTest
@@ -1936,6 +1954,7 @@ public class TestHoodieLogFormat extends
HoodieCommonTestHarness {
assertEquals(expectedBlockInstants, validBlockInstants);
Collections.sort(readKeys);
assertEquals(expectedRecords, readKeys, "Record keys read should be
exactly same.");
+ scanner.close();
}
/*
@@ -2013,7 +2032,7 @@ public class TestHoodieLogFormat extends
HoodieCommonTestHarness {
assertEquals(Math.max(numRecordsInLog1, numRecordsInLog2),
scanner.getNumMergedRecordsInLog(),
"We would read 100 records");
-
+ scanner.close();
} catch (Exception e) {
e.printStackTrace();
}
