xushiyan commented on code in PR #6824:
URL: https://github.com/apache/hudi/pull/6824#discussion_r1000114134
##########
hudi-spark-datasource/hudi-spark/src/main/scala/org/apache/spark/sql/hudi/command/MergeIntoHoodieTableCommand.scala:
##########
@@ -160,7 +167,7 @@ case class MergeIntoHoodieTableCommand(mergeInto:
MergeIntoTable) extends Hoodie
// column order changed after left anti join , we should keep column
order of source dataframe
val cols = removeMetaFields(sourceDF).columns
- executeInsertOnly(insertSourceDF.select(cols.head, cols.tail:_*),
parameters)
+ executeInsertOnly(insertSourceDF.select(cols.head, cols.tail:_*),
writeParam)
Review Comment:
@KnightChess i think in the case of merge into, if we can set
`hoodie.combine.before.insert` to true when precombine field is set, and keep
the operation type still `insert` to align with "when not matched then insert
*" where `insert` was used. Changing operation type leads to implementation
inconsistency - even the method is called `executeInsertOnly()`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
