yesemsanthoshkumar commented on code in PR #6726:
URL: https://github.com/apache/hudi/pull/6726#discussion_r1000163418
##########
hudi-utilities/src/test/java/org/apache/hudi/utilities/functional/TestHoodieMultiTableDeltaStreamer.java:
##########
@@ -245,10 +246,13 @@ public void testTableLevelProperties() throws IOException
{
case "dummy_table_short_trip":
String tableLevelKeyGeneratorClass =
tableExecutionContext.getProperties().getString(DataSourceWriteOptions.KEYGENERATOR_CLASS_NAME().key());
assertEquals(TestHoodieDeltaStreamer.TestTableLevelGenerator.class.getName(),
tableLevelKeyGeneratorClass);
+ List<String> transformerClass =
tableExecutionContext.getConfig().transformerClassNames;
Review Comment:
I've added these as tests for checking the transformers. Let me know your
thoughts on this. I'm not sure if this is the what you expect.
I'm yet to look at the failed builds. And sure. Will rebase to latest master.
##########
hudi-utilities/src/test/java/org/apache/hudi/utilities/functional/TestHoodieMultiTableDeltaStreamer.java:
##########
@@ -245,10 +246,13 @@ public void testTableLevelProperties() throws IOException
{
case "dummy_table_short_trip":
String tableLevelKeyGeneratorClass =
tableExecutionContext.getProperties().getString(DataSourceWriteOptions.KEYGENERATOR_CLASS_NAME().key());
assertEquals(TestHoodieDeltaStreamer.TestTableLevelGenerator.class.getName(),
tableLevelKeyGeneratorClass);
+ List<String> transformerClass =
tableExecutionContext.getConfig().transformerClassNames;
Review Comment:
@nsivabalan I've added these as tests for checking the transformers. Let me
know your thoughts on this. I'm not sure if this is the what you expect.
I'm yet to look at the failed builds. And sure. Will rebase to latest master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
