nsivabalan commented on code in PR #7020:
URL: https://github.com/apache/hudi/pull/7020#discussion_r1003859249


##########
hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/table/action/compact/TestInlineCompaction.java:
##########
@@ -229,6 +229,9 @@ public void testSuccessfulCompactionBasedOnNumAndTime() 
throws Exception {
 
       // Then: ensure no compaction is executed since there are only 3 delta 
commits
       assertEquals(3, 
metaClient.getActiveTimeline().getWriteTimeline().countInstants());
+
+      // Ensure the elapsed time > INLINE_COMPACT_TIME_DELTA_SECONDS
+      Thread.sleep(60 * 1000);

Review Comment:
   may I know why its flaky and why would this fix mitigate it. From what I 
see, we are setting trigger strategy to NUM_AND_TIME. 
   why switching from 20 to 60 secs would work consistently ? 
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to