xushiyan commented on code in PR #6227:
URL: https://github.com/apache/hudi/pull/6227#discussion_r1006119882
##########
packaging/hudi-flink-bundle/pom.xml:
##########
@@ -639,7 +639,6 @@
<groupId>org.apache.orc</groupId>
<artifactId>orc-core</artifactId>
<version>${orc.version}</version>
- <classifier>nohive</classifier>
Review Comment:
in principle hudi should not include file formats in the bundles, and just
use provided ones and also make sure hudi using APIs correctly. But if we
include some libs, we should shade for hudi's use. There are inconsistencies
about this across bundles, for flink bundle, avro is shaded but parquet is not.
When you say "interfacing w/ the execution engine" it's meant for class
loading, which should be addressed at code level, like avoid calling APIs that
load hardcoded classes, which i think it's rare situations (Kryo is one of
those)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
