xicm commented on code in PR #7068:
URL: https://github.com/apache/hudi/pull/7068#discussion_r1007668806
##########
hudi-sync/hudi-hive-sync/src/main/java/org/apache/hudi/hive/HiveSyncConfig.java:
##########
@@ -108,45 +108,45 @@ public static class HiveSyncConfigParams {
+ "instead of org.apache.hudi package. Use this when you are in
the process of migrating from "
+ "com.uber.hoodie to org.apache.hudi. Stop using this after you
migrated the table definition to "
+ "org.apache.hudi input format.")
- public Boolean usePreApacheInputFormat;
+ public boolean usePreApacheInputFormat;
@Deprecated
- @Parameter(names = {"--use-jdbc"}, description = "Hive jdbc connect url")
- public Boolean useJdbc;
+ @Parameter(names = {"--use-jdbc"}, description = "Hive jdbc connect url",
arity = 1)
+ public Boolean useJdbc = true;
@Parameter(names = {"--metastore-uris"}, description = "Hive metastore
uris")
public String metastoreUris;
@Parameter(names = {"--sync-mode"}, description = "Mode to choose for Hive
ops. Valid values are hms,glue,jdbc and hiveql")
public String syncMode;
- @Parameter(names = {"--auto-create-database"}, description = "Auto create
hive database")
- public Boolean autoCreateDatabase;
+ @Parameter(names = {"--auto-create-database"}, description = "Auto create
hive database", arity = 1)
+ public boolean autoCreateDatabase = true;
@Parameter(names = {"--ignore-exceptions"}, description = "Ignore hive
exceptions")
- public Boolean ignoreExceptions;
+ public boolean ignoreExceptions;
Review Comment:
@xushiyan The change of the default value is a problem.
Double check with you, is it ok to do like this
```boolean useJdbc = Boolean.parseBoolean(HIVE_USE_JDBC.defaultValue());```
That means for boolean params we must pass "--key true/false" instead of
"--key" if we want to overwrite the default value.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
