umehrot2 commented on a change in pull request #1559:
URL: https://github.com/apache/incubator-hudi/pull/1559#discussion_r417020450
##########
File path:
hudi-common/src/main/java/org/apache/hudi/common/table/TableSchemaResolver.java
##########
@@ -178,6 +193,17 @@ public Schema convertParquetSchemaToAvro(MessageType
parquetSchema) {
return avroSchemaConverter.convert(parquetSchema);
}
+ /**
+ * Convert a avro scheme to the parquet format.
+ *
+ * @param schema The avro schema to convert
+ * @return The converted parquet schema
+ */
+ public MessageType convertAvroSchemaToParquet(Schema schema) {
Review comment:
There is nothing really that we can re-use from ParquetUtils for the
purpose of this PR. The APIs in ParquetUtils class accept a file path from
which to read. However, here it first needs to go through the active timeline
and find out the file path and then read the schema. The reading from file
functions of this class can internally re-use some of the APIs from
ParquetUtils but I don't think we should touch it as part of this PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
