hddong commented on a change in pull request #1567:
URL: https://github.com/apache/incubator-hudi/pull/1567#discussion_r417047280
##########
File path:
hudi-common/src/main/java/org/apache/hudi/common/table/log/HoodieLogFormatWriter.java
##########
@@ -210,6 +210,14 @@ public void close() throws IOException {
flush();
output.close();
output = null;
+ Path path = logFile.getPath();
Review comment:
> @hddong : Any possible reasons why blank file is created in the first
place ?
Create blank file for `appendBlock` when new `HoodieLogFormatWriter`
https://github.com/apache/incubator-hudi/blob/f1592be629c3f9762f62d4e1dbf3be54f213d92d/hudi-common/src/main/java/org/apache/hudi/common/table/log/HoodieLogFormatWriter.java#L105-L108
But there is a special case, when roll over is true(block size is past the
threshold), we will close the old writer and create a new writer . And if we
close a new writer created by `rolloverIfNeeded` , there will left a blank file.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
