JerryYue-M commented on code in PR #7099:
URL: https://github.com/apache/hudi/pull/7099#discussion_r1010032811


##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/sink/common/AbstractWriteFunction.java:
##########
@@ -45,4 +92,46 @@
    * @param event The event
    */
   public abstract void handleOperatorEvent(OperatorEvent event);
+
+  /**
+   *  Extract TimeStamp from input value with specified event time field.
+   * @param value The input value
+   * @return the new timestamp for current.
+   */
+  public  long extractTimestamp(I value) {
+    if (value instanceof HoodieAvroRecord) {
+      return extractTimestamp((HoodieAvroRecord) value);
+    }
+    return extractTimestamp((RowData) value);
+  }

Review Comment:
   The reason why put it here is BulkInsertWriteFunction only extends 
BulkInsertWriteFunction instead of AbstractStreamWriteFunction, if moving this 
code to AbstractStreamWriteFunction will make a specified way to deal with 
BulkInsertWriteFunction



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to