danny0405 commented on code in PR #6491:
URL: https://github.com/apache/hudi/pull/6491#discussion_r1010108844
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/util/StreamerUtil.java:
##########
@@ -257,6 +260,18 @@ public static HoodiePayloadConfig
getPayloadConfig(Configuration conf) {
.build();
}
+ /**
+ * Returns write commit callback config with given configuration.
+ * @param conf the configuration
+ * @return a HoodieWriteCommitCallbackConfig instance
+ */
+ private static HoodieWriteCommitCallbackConfig
getWriteCommitCallbackConfig(Configuration conf) {
+ Properties properties = new Properties();
+ properties.putAll(FlinkOptions.getPropertiesWithPrefix(conf.toMap(),
CALLBACK_PREFIX));
+ return HoodieWriteCommitCallbackConfig.newBuilder()
+ .fromProperties(properties).build();
Review Comment:
Shouldn't `HoodieWriteConfig#setDefaults` already handle the
`HoodieWriteCommitCallbackConfig` logic ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
