nsivabalan commented on code in PR #7076:
URL: https://github.com/apache/hudi/pull/7076#discussion_r1012271387
##########
hudi-cli/src/main/java/org/apache/hudi/cli/commands/ArchivedCommitsCommand.java:
##########
@@ -52,6 +60,37 @@
*/
@ShellComponent
public class ArchivedCommitsCommand {
+ private static final Logger LOG =
LogManager.getLogger(ArchivedCommitsCommand.class);
+ @ShellMethod(key = "trigger archival", value = "trigger archival")
+ public String triggerArchival(
+ @ShellOption(value = {"--minCommits"},
+ help = "Minimum number of instants to retain in the active timeline.
See hoodie.keep.min.commits",
+ defaultValue = "20") int minCommits,
+ @ShellOption(value = {"--maxCommits"},
+ help = "Maximum number of instants to retain in the active timeline.
See hoodie.keep.max.commits",
+ defaultValue = "30") int maxCommits,
+ @ShellOption(value = {"--commitsRetained"}, help = "Number of commits to
retain, without cleaning",
Review Comment:
lets rename to "commitsRetainedByCleaner" so its apparent
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
