xiarixiaoyao commented on code in PR #7129:
URL: https://github.com/apache/hudi/pull/7129#discussion_r1013530563


##########
hudi-hadoop-mr/src/main/java/org/apache/hudi/hadoop/HoodieParquetInputFormat.java:
##########
@@ -45,7 +46,8 @@
  */
 @UseRecordReaderFromInputFormat
 @UseFileSplitsFromInputFormat
-public class HoodieParquetInputFormat extends HoodieParquetInputFormatBase {
+public class HoodieParquetInputFormat extends HoodieParquetInputFormatBase 
implements
+    SelfDescribingInputFormatInterface {

Review Comment:
   it will be better to implements SelfDescribingInputFormatInterface by 
HoodieParquetInputFormatBase
   let's move this change to HoodieParquetInputFormatBase
   
   public abstract class HoodieParquetInputFormatBase extends 
MapredParquetInputFormat implements Configurable, 
SelfDescribingInputFormatInterface



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to