yihua commented on code in PR #7035:
URL: https://github.com/apache/hudi/pull/7035#discussion_r1015847808
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieWriteConfig.java:
##########
@@ -1335,10 +1335,14 @@ public boolean isClusteringEnabled() {
return inlineClusteringEnabled() || isAsyncClusteringEnabled();
}
- public boolean isRollbackPendingClustering() {
+ public boolean isRollbackPendingClusteringOnConflict() {
return
getBoolean(HoodieClusteringConfig.ROLLBACK_PENDING_CLUSTERING_ON_CONFLICT);
}
+ public boolean isRollbackPendingClustering() {
+ return getBoolean(HoodieClusteringConfig.ROLLBACK_PENDING_CLUSTERING);
+ }
+
Review Comment:
Note that `withRollbackPendingClustering()` and
`isRollbackPendingClustering()` are public methods. Any code outside Hudi repo
using these two APIs will be affected by this implicit semantics change. If
you insist on the changes, let's create a documentation update to call it out.
But I would rather keep the naming the same to avoid any behavior change for
the same APIs and focus on better naming for any new APIs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
