danny0405 commented on code in PR #6939:
URL: https://github.com/apache/hudi/pull/6939#discussion_r1016121108
##########
hudi-common/src/main/java/org/apache/hudi/common/table/log/HoodieLogFormatWriter.java:
##########
@@ -220,6 +220,7 @@ private void rolloverIfNeeded() throws IOException {
LOG.info("CurrentSize " + getCurrentSize() + " has reached threshold " +
sizeThreshold
+ ". Rolling over to the next version");
rollOver();
+ createNewFile();
}
Review Comment:
We better not generate a new physical file handle when rollover, the good
strategy is: only generate a new file handle when we want to write real data
set.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
