xushiyan commented on code in PR #7037:
URL: https://github.com/apache/hudi/pull/7037#discussion_r1016342441
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/BaseActionExecutor.java:
##########
@@ -58,7 +59,7 @@ public BaseActionExecutor(HoodieEngineContext context,
HoodieWriteConfig config,
*/
protected final void writeTableMetadata(HoodieCommitMetadata metadata,
String actionType) {
table.getMetadataWriter(instantTime).ifPresent(w -> w.update(
- metadata, instantTime, table.isTableServiceAction(actionType)));
+ metadata, instantTime, table.isTableServiceAction(new
HoodieInstant(HoodieInstant.State.INFLIGHT, actionType, instantTime))));
Review Comment:
@nsivabalan seeing there is
`org.apache.hudi.common.table.timeline.HoodieInstant.State#INVALID` which is
only used by tests, so we can change it to something like `NIL` and use it for
this scenario? At least to make it clear that this is a dummy instant, better
than marking it inflight.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
