YannByron commented on code in PR #7175:
URL: https://github.com/apache/hudi/pull/7175#discussion_r1019774239
##########
hudi-common/src/test/java/org/apache/hudi/common/model/TestOverwriteNonDefaultsWithLatestAvroPayload.java:
##########
@@ -181,10 +181,10 @@ public void testDeletedRecord() throws IOException {
@Test
public void testNullColumn() throws IOException {
Schema avroSchema = Schema.createRecord(Arrays.asList(
- new Schema.Field("id",
Schema.createUnion(Schema.create(Schema.Type.STRING),
Schema.create(Schema.Type.NULL)), "", JsonProperties.NULL_VALUE),
- new Schema.Field("name",
Schema.createUnion(Schema.create(Schema.Type.STRING),
Schema.create(Schema.Type.NULL)), "", JsonProperties.NULL_VALUE),
- new Schema.Field("age",
Schema.createUnion(Schema.create(Schema.Type.STRING),
Schema.create(Schema.Type.NULL)), "", JsonProperties.NULL_VALUE),
- new Schema.Field("job",
Schema.createUnion(Schema.create(Schema.Type.STRING),
Schema.create(Schema.Type.NULL)), "", JsonProperties.NULL_VALUE)
+ new Schema.Field("id",
Schema.createUnion(Schema.create(Schema.Type.NULL),
Schema.create(Schema.Type.STRING)), "", JsonProperties.NULL_VALUE),
Review Comment:
why we need to change this.
##########
hudi-common/src/test/java/org/apache/hudi/common/model/TestPartialUpdateAvroPayload.java:
##########
@@ -55,7 +55,7 @@ public class TestPartialUpdateAvroPayload {
+ " {\"name\": \"id\", \"type\": [\"null\", \"string\"]},\n"
+ " {\"name\": \"partition\", \"type\": [\"null\", \"string\"]},\n"
+ " {\"name\": \"ts\", \"type\": [\"null\", \"long\"]},\n"
- + " {\"name\": \"_hoodie_is_deleted\", \"type\": [\"null\",
\"boolean\"], \"default\":false},\n"
+ + " {\"name\": \"_hoodie_is_deleted\", \"type\": [\"boolean\",
\"null\"], \"default\":false},\n"
Review Comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
