alexeykudinkin commented on code in PR #7088:
URL: https://github.com/apache/hudi/pull/7088#discussion_r1020534097
##########
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/DataSourceOptions.scala:
##########
@@ -91,7 +90,7 @@ object DataSourceReadOptions {
val ENABLE_HOODIE_FILE_INDEX: ConfigProperty[Boolean] = ConfigProperty
.key("hoodie.file.index.enable")
- .defaultValue(true)
+ .defaultValue(false)
Review Comment:
Don't forget to revert this
##########
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/BaseFileOnlyRelation.scala:
##########
@@ -134,7 +135,9 @@ class BaseFileOnlyRelation(sqlContext: SQLContext,
* rule; you can find more details in HUDI-3896)
*/
def toHadoopFsRelation: HadoopFsRelation = {
- if (globPaths.isEmpty) {
+ val enableFileIndex = optParams.get(ENABLE_HOODIE_FILE_INDEX.key)
+ .map(_.toBoolean).getOrElse(ENABLE_HOODIE_FILE_INDEX.defaultValue)
+ if (globPaths.isEmpty && enableFileIndex) {
Review Comment:
nit: let's flip the order, to stress relative importance
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
