xushiyan commented on code in PR #7181:
URL: https://github.com/apache/hudi/pull/7181#discussion_r1020842710
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metrics/HoodieMetrics.java:
##########
@@ -175,6 +175,7 @@ public void updateMetricsForEmptyData(String actionType) {
Metrics.registerGauge(getMetricsName(actionType,
"totalCompactedRecordsUpdated"), 0);
Metrics.registerGauge(getMetricsName(actionType,
"totalLogFilesCompacted"), 0);
Metrics.registerGauge(getMetricsName(actionType, "totalLogFilesSize"), 0);
+ Metrics.registerGauge(getMetricsName(actionType, "totalRecordsDeleted"),
0);
Review Comment:
/nit would prefer to have this line moved up after
"totalInsertRecordsWritten" so similar metrics grouped together
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metrics/HoodieMetrics.java:
##########
@@ -194,6 +195,7 @@ public void updateCommitMetrics(long commitEpochTimeInMs,
long durationInMs, Hoo
long totalCompactedRecordsUpdated =
metadata.getTotalCompactedRecordsUpdated();
long totalLogFilesCompacted = metadata.getTotalLogFilesCompacted();
long totalLogFilesSize = metadata.getTotalLogFilesSize();
+ long totalRecordsDeleted = metadata.getTotalRecordsDeleted();
Review Comment:
ditto; apply to other changes too
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
