[hudi] branch master updated: [HUDI-5201] Add totalRecordsDeleted metric (#7181)

[xushiyan]

This is an automated email from the ASF dual-hosted git repository.

xushiyan pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/hudi.git


The following commit(s) were added to refs/heads/master by this push:
     new 5ac605c9e7 [HUDI-5201] Add totalRecordsDeleted metric (#7181)
5ac605c9e7 is described below

commit 5ac605c9e76379a03cf554b64059d049d5b786b1
Author: Hussein Awala <houssein.awala...@gmail.com>
AuthorDate: Mon Nov 14 04:29:52 2022 +0100

    [HUDI-5201] Add totalRecordsDeleted metric (#7181)
---
 .../src/main/java/org/apache/hudi/metrics/HoodieMetrics.java       | 3 +++
 .../src/test/java/org/apache/hudi/metrics/TestHoodieMetrics.java   | 7 +++++--
 2 files changed, 8 insertions(+), 2 deletions(-)

diff --git 
a/hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metrics/HoodieMetrics.java
 
b/hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metrics/HoodieMetrics.java
index 6bc91d0459..7b34bb4817 100644
--- 
a/hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metrics/HoodieMetrics.java
+++ 
b/hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metrics/HoodieMetrics.java
@@ -168,6 +168,7 @@ public class HoodieMetrics {
     Metrics.registerGauge(getMetricsName(actionType, "totalRecordsWritten"), 
0);
     Metrics.registerGauge(getMetricsName(actionType, 
"totalUpdateRecordsWritten"), 0);
     Metrics.registerGauge(getMetricsName(actionType, 
"totalInsertRecordsWritten"), 0);
+    Metrics.registerGauge(getMetricsName(actionType, "totalRecordsDeleted"), 
0);
     Metrics.registerGauge(getMetricsName(actionType, "totalBytesWritten"), 0);
     Metrics.registerGauge(getMetricsName(actionType, "totalScanTime"), 0);
     Metrics.registerGauge(getMetricsName(actionType, "totalCreateTime"), 0);
@@ -187,6 +188,7 @@ public class HoodieMetrics {
       long totalRecordsWritten = metadata.fetchTotalRecordsWritten();
       long totalUpdateRecordsWritten = 
metadata.fetchTotalUpdateRecordsWritten();
       long totalInsertRecordsWritten = 
metadata.fetchTotalInsertRecordsWritten();
+      long totalRecordsDeleted = metadata.getTotalRecordsDeleted();
       long totalBytesWritten = metadata.fetchTotalBytesWritten();
       long totalTimeTakenByScanner = metadata.getTotalScanTime();
       long totalTimeTakenForInsert = metadata.getTotalCreateTime();
@@ -207,6 +209,7 @@ public class HoodieMetrics {
       Metrics.registerGauge(getMetricsName(actionType, 
"totalCompactedRecordsUpdated"), totalCompactedRecordsUpdated);
       Metrics.registerGauge(getMetricsName(actionType, 
"totalLogFilesCompacted"), totalLogFilesCompacted);
       Metrics.registerGauge(getMetricsName(actionType, "totalLogFilesSize"), 
totalLogFilesSize);
+      Metrics.registerGauge(getMetricsName(actionType, "totalRecordsDeleted"), 
totalRecordsDeleted);
     }
   }
 
diff --git 
a/hudi-client/hudi-client-common/src/test/java/org/apache/hudi/metrics/TestHoodieMetrics.java
 
b/hudi-client/hudi-client-common/src/test/java/org/apache/hudi/metrics/TestHoodieMetrics.java
index a5ea531c92..02b1a28531 100755
--- 
a/hudi-client/hudi-client-common/src/test/java/org/apache/hudi/metrics/TestHoodieMetrics.java
+++ 
b/hudi-client/hudi-client-common/src/test/java/org/apache/hudi/metrics/TestHoodieMetrics.java
@@ -137,8 +137,9 @@ public class TestHoodieMetrics {
       when(metadata.getTotalCompactedRecordsUpdated()).thenReturn(randomValue 
+ 11);
       when(metadata.getTotalLogFilesCompacted()).thenReturn(randomValue + 12);
       when(metadata.getTotalLogFilesSize()).thenReturn(randomValue + 13);
+      when(metadata.getTotalRecordsDeleted()).thenReturn(randomValue + 14);
       
when(metadata.getMinAndMaxEventTime()).thenReturn(Pair.of(Option.empty(), 
Option.empty()));
-      metrics.updateCommitMetrics(randomValue + 14, commitTimer.stop(), 
metadata, action);
+      metrics.updateCommitMetrics(randomValue + 15, commitTimer.stop(), 
metadata, action);
 
       String metricname = metrics.getMetricsName(action, "duration");
       long duration = 
(Long)Metrics.getInstance().getRegistry().getGauges().get(metricname).getValue();
@@ -158,7 +159,7 @@ public class TestHoodieMetrics {
       metricname = metrics.getMetricsName(action, "totalBytesWritten");
       
assertEquals((long)Metrics.getInstance().getRegistry().getGauges().get(metricname).getValue(),
 metadata.fetchTotalBytesWritten());
       metricname = metrics.getMetricsName(action, "commitTime");
-      
assertEquals((long)Metrics.getInstance().getRegistry().getGauges().get(metricname).getValue(),
 randomValue + 14);
+      
assertEquals((long)Metrics.getInstance().getRegistry().getGauges().get(metricname).getValue(),
 randomValue + 15);
       metricname = metrics.getMetricsName(action, "totalScanTime");
       
assertEquals(Metrics.getInstance().getRegistry().getGauges().get(metricname).getValue(),
 metadata.getTotalScanTime());
       metricname = metrics.getMetricsName(action, "totalCreateTime");
@@ -171,6 +172,8 @@ public class TestHoodieMetrics {
       
assertEquals(Metrics.getInstance().getRegistry().getGauges().get(metricname).getValue(),
 metadata.getTotalLogFilesCompacted());
       metricname = metrics.getMetricsName(action, "totalLogFilesSize");
       
assertEquals(Metrics.getInstance().getRegistry().getGauges().get(metricname).getValue(),
 metadata.getTotalLogFilesSize());
+      metricname = metrics.getMetricsName(action, "totalRecordsDeleted");
+      
assertEquals(Metrics.getInstance().getRegistry().getGauges().get(metricname).getValue(),
 metadata.getTotalRecordsDeleted());
     });
   }
 }