alexeykudinkin commented on PR #6843:
URL: https://github.com/apache/hudi/pull/6843#issuecomment-1314319731
Hey, @zhangyue19921010!
Yeah, this PR was put up purely for experimental purposes even before we
finalized previous PR landing disruptor which (considerably improved the API!),
so i was primarily looking into putting up quick solution i can quickly
benchmark against and validate.
In terms of taking this forward, i have following thoughts:
- We should try to preserve existing queue implementations, so that users
could experiment in their environment and always pick what works best for
them.
- This variability of course should not be coming at the expense of
performance.
- We should maybe take another holistic look on the executor APIs and try
to see if we can simplify them even further (by, say, eliminating what we don't
really need)
Our goal would be to fit in such `SimpleExecutor` into existing framework
in a way that would allow all of the aforementioned ones to hold true.
P.S. What surprised me actually was that i was NOT able to reproduce 20%
increase in performance for Disruptor on our benchmarks that you folks were
seeing in your environment. First issue was due to #7188, but even after
addressing it i still don't see an improvement.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
