alexeykudinkin commented on code in PR #7167:
URL: https://github.com/apache/hudi/pull/7167#discussion_r1022024452
##########
hudi-common/src/main/java/org/apache/hudi/common/model/AWSDmsAvroPayload.java:
##########
@@ -69,7 +75,15 @@ private Option<IndexedRecord>
handleDeleteOperation(IndexedRecord insertValue) t
@Override
public Option<IndexedRecord> getInsertValue(Schema schema, Properties
properties) throws IOException {
- return getInsertValue(schema);
+ boolean dropPartCol =
Boolean.parseBoolean(properties.getProperty(HoodieTableConfig.DROP_PARTITION_COLUMNS.key()));
Review Comment:
This is not the right way to fix this:
- Record payload itself should not be manipulating the schema -- it should
rely on the correctness of the schema passed in externally.
- It should be responsibility of the caller it uses appropriate schema to
decode the record
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
