alexeykudinkin commented on code in PR #6725:
URL: https://github.com/apache/hudi/pull/6725#discussion_r1022028238


##########
hudi-sync/hudi-hive-sync/src/main/java/org/apache/hudi/hive/HiveSyncConfig.java:
##########
@@ -65,6 +65,17 @@ public class HiveSyncConfig extends HoodieSyncConfig {
   public static final ConfigProperty<String> HIVE_SYNC_BUCKET_SYNC_SPEC = 
HiveSyncConfigHolder.HIVE_SYNC_BUCKET_SYNC_SPEC;
   public static final ConfigProperty<String> HIVE_SYNC_COMMENT = 
HiveSyncConfigHolder.HIVE_SYNC_COMMENT;
 
+  public static final ConfigProperty<Boolean> HIVE_SYNC_FILTER_PUSHDOWN_ENABLE 
= ConfigProperty
+      .key("hoodie.datasource.hive_sync.filter_pushdown_enable")

Review Comment:
   Surely, let's keep `hive_sync` to stay compatible w/ other props, but we 
should not proliferate this and instead make sure we converge across all of the 
properties we have (default convention is to use hyphens and dots as delimeters)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to