danny0405 commented on PR #7189: URL: https://github.com/apache/hudi/pull/7189#issuecomment-1314873310
Thanks for the contribution @KevinyhZou , somehow i feel the PR is valuable and we can generalize it to all the writer cases: append mode, upsert, and we can move the partition check done file writing logic into the coordinator. The watermark timestamp can be reported through the `WriteMetadataEvent`. And another concern is: the watermark is already a timestamp and do we have a need for different kind of timestamp formatter ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
