danny0405 commented on code in PR #7196:
URL: https://github.com/apache/hudi/pull/7196#discussion_r1022435179
##########
hudi-common/src/main/java/org/apache/hudi/common/table/timeline/HoodieActiveTimeline.java:
##########
@@ -257,46 +257,36 @@ public static void deleteInstantFile(FileSystem fs,
String metaPath, HoodieInsta
public void deleteEmptyInstantIfExists(HoodieInstant instant) {
ValidationUtils.checkArgument(isEmpty(instant));
- deleteInstantFileIfExists(instant);
+ deleteInstantIfExists(instant);
}
public void deleteCompactionRequested(HoodieInstant instant) {
ValidationUtils.checkArgument(instant.isRequested());
ValidationUtils.checkArgument(Objects.equals(instant.getAction(),
HoodieTimeline.COMPACTION_ACTION));
- deleteInstantFile(instant);
+ deleteInstantIfExists(instant);
}
- public void deleteInstantFileIfExists(HoodieInstant instant) {
- LOG.info("Deleting instant " + instant);
- Path inFlightCommitFilePath =
getInstantFileNamePath(instant.getFileName());
- try {
- if (metaClient.getFs().exists(inFlightCommitFilePath)) {
- boolean result = metaClient.getFs().delete(inFlightCommitFilePath,
false);
Review Comment:
Seems the core change is renaming a method here: `deleteInstantFileIfExists`
-> `deleteInstantIfExists` ? If that is true, i would suggest to keep as it is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
