yihua commented on code in PR #7211:
URL: https://github.com/apache/hudi/pull/7211#discussion_r1023463115
##########
hudi-timeline-service/src/main/java/org/apache/hudi/timeline/service/TimelineService.java:
##########
@@ -263,10 +265,12 @@ private int startServiceOnPort(int port) throws
IOException {
}
public int startService() throws IOException {
- final Server server = timelineServerConf.numThreads == DEFAULT_NUM_THREADS
? new Server() : new Server(new
QueuedThreadPool(timelineServerConf.numThreads));
-
+ final Server server = timelineServerConf.numThreads == DEFAULT_NUM_THREADS
? new JettyServer(new JavalinConfig()).server() :
Review Comment:
@rahil-c Is the change to `new JettyServer(new JavalinConfig()).server()`
due to Javalin upgrade? I only see minor version upgrade for Javalin and am
wondering if this is really needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
