trushev opened a new pull request, #7228:
URL: https://github.com/apache/hudi/pull/7228

   ### Change Logs
   
   We need to override equals because the check `intType1 == intType2` can 
return `false`.
   Despite the fact that most subclasses of `Type` look like singleton with 
static field `INSTANCE`, they can still be created by **deserializer**. It 
means that the check below always returns `true` 
[InternalSchemaUtils.java](https://github.com/apache/hudi/blob/6b0b03b12b5b35efd16eb976d48edba876803ca0/hudi-common/src/main/java/org/apache/hudi/internal/schema/utils/InternalSchemaUtils.java#L211-L225):
   ```java
   if (!schema.findType(f).equals(oldSchema.findType(f))) {
   ```
   
   ### Impact
   
   `InternalSchemaUtils.collectTypeChangedCols` returns only changed columns
   
   ### Risk level
   
   Low
   
   ### Documentation Update
   
   None
   
   ### Contributor's checklist
   
   - [ ] Read through [contributor's 
guide](https://hudi.apache.org/contribute/how-to-contribute)
   - [ ] Change Logs and Impact were stated clearly
   - [ ] Adequate tests were added if applicable
   - [ ] CI passed
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to