xiarixiaoyao commented on code in PR #6358:
URL: https://github.com/apache/hudi/pull/6358#discussion_r1025155407
##########
hudi-common/src/main/java/org/apache/hudi/avro/HoodieAvroUtils.java:
##########
@@ -867,12 +870,8 @@ private static String createFullName(Deque<String>
fieldNames) {
}
private static Object rewritePrimaryType(Object oldValue, Schema oldSchema,
Schema newSchema) {
- Schema realOldSchema = oldSchema;
- if (realOldSchema.getType() == UNION) {
- realOldSchema = getActualSchemaFromUnion(oldSchema, oldValue);
- }
- if (realOldSchema.getType() == newSchema.getType()) {
- switch (realOldSchema.getType()) {
+ if (oldSchema.getType() == newSchema.getType()) {
+ switch (oldSchema.getType()) {
Review Comment:
why remove those code,
i remember this is a bug fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
