trushev commented on code in PR #6358:
URL: https://github.com/apache/hudi/pull/6358#discussion_r1025925085
##########
hudi-client/hudi-flink-client/src/main/java/org/apache/hudi/table/HoodieFlinkCopyOnWriteTable.java:
##########
@@ -378,7 +377,7 @@ protected Iterator<List<WriteStatus>>
handleUpdateInternal(HoodieMergeHandle<?,
throw new HoodieUpsertException(
"Error in finding the old file path at commit " + instantTime + "
for fileId: " + fileId);
} else {
- FlinkMergeHelper.newInstance().runMerge(this, upsertHandle);
+ HoodieMergeHelper.newInstance().runMerge(this, upsertHandle);
Review Comment:
+1 on removing `FlinkMergeHelper` in a seprarete PR
Currently, there is another huge PR affecting `BaseMergeHelper` and its
subclasses https://github.com/apache/hudi/pull/5830.
The day will come when one of us will have to solve merge conflict with
master branch.
I'd prefer to do it ASAP because no `FlinkMergeHelper` means no conflict:)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
