wzx140 commented on code in PR #7003:
URL: https://github.com/apache/hudi/pull/7003#discussion_r1027294579
##########
hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/spark/sql/hudi/TestSpark3DDL.scala:
##########
@@ -531,6 +533,18 @@ class TestSpark3DDL extends HoodieSparkSqlTestBase {
)
}
}
+ })
+ }
+
+ val sparkOpts = Map(
+ HoodieWriteConfig.MERGER_IMPLS.key ->
classOf[HoodieSparkRecordMerger].getName,
+ HoodieStorageConfig.LOGFILE_DATA_BLOCK_FORMAT.key -> "parquet"
+ )
+
+ def getOpts(recordType: HoodieRecordType, opt: Map[String, String]):
(Map[String, String], Map[String, String]) = {
Review Comment:
fixed
##########
hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/hudi/functional/TestMORDataSource.scala:
##########
@@ -1228,18 +1232,10 @@ class TestMORDataSource extends HoodieClientTestBase
with SparkDatasetMixin {
roDf.where(col(recordKeyField) ===
0).select(dataField).collect()(0).getLong(0))
}
- def getOpts(recordType: HoodieRecordType): (Map[String, String], Map[String,
String]) = {
- val writeOpts = if (recordType == HoodieRecordType.SPARK) {
- commonOpts ++ sparkOpts
- } else {
- commonOpts
+ def getOpts(recordType: HoodieRecordType, opt: Map[String, String] =
commonOpts): (Map[String, String], Map[String, String]) = {
Review Comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
