nsivabalan commented on code in PR #7038:
URL: https://github.com/apache/hudi/pull/7038#discussion_r1028909307
##########
hudi-utilities/src/main/java/org/apache/hudi/utilities/deltastreamer/DeltaSync.java:
##########
@@ -499,7 +499,7 @@ private Pair<SchemaProvider, Pair<String,
JavaRDD<HoodieRecord>>> fetchFromSourc
return new HoodieAvroRecord<>(keyGenerator.getKey(record), payload);
});
- return Pair.of(schemaProvider, Pair.of(checkpointStr, records));
+ return new ReadResult(schemaProvider, checkpointStr, records, false);
Review Comment:
synced up offline. we end up calling isEmpty twice only when filterDupes is
set. for most common use-case, we just call it once.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
