codope commented on code in PR #7038:
URL: https://github.com/apache/hudi/pull/7038#discussion_r1029206231


##########
hudi-utilities/src/main/java/org/apache/hudi/utilities/deltastreamer/DeltaSync.java:
##########
@@ -333,18 +333,18 @@ public Pair<Option<String>, JavaRDD<WriteStatus>> 
syncOnce() throws IOException
     // Refresh Timeline
     refreshTimeline();
 
-    Pair<SchemaProvider, Pair<String, JavaRDD<HoodieRecord>>> 
srcRecordsWithCkpt = readFromSource(commitTimelineOpt);
+    ReadResult readResult = readFromSource(commitTimelineOpt);

Review Comment:
   Integ test module build failed due to
   ```
   Error:  
/home/runner/work/hudi/hudi/hudi-integ-test/src/main/java/org/apache/hudi/integ/testsuite/HoodieDeltaStreamerWrapper.java:[81,34]
 incompatible types: 
org.apache.hudi.utilities.deltastreamer.DeltaSync.ReadResult cannot be 
converted to 
org.apache.hudi.common.util.collection.Pair<org.apache.hudi.utilities.schema.SchemaProvider,org.apache.hudi.common.util.collection.Pair<java.lang.String,org.apache.spark.api.java.JavaRDD<org.apache.hudi.common.model.HoodieRecord>>>
   ```
   Looks like we need to change the HoodieDeltaStreamerWrapper in the test to 
provide same return type.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to