codope commented on code in PR #7269:
URL: https://github.com/apache/hudi/pull/7269#discussion_r1030413352
##########
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/spark/sql/hudi/ProvidesHoodieConfig.scala:
##########
@@ -165,10 +165,14 @@ trait ProvidesHoodieConfig extends Logging {
// Only validate duplicate key for COW, for MOR it will do the merge
with the DefaultHoodieRecordPayload
// on reading.
classOf[ValidateDuplicateKeyPayload].getCanonicalName
+ } else if (operation == INSERT_OPERATION_OPT_VAL &&
+ tableType == COW_TABLE_TYPE_OPT_VAL && hasPrecombineColumn == false &&
insertMode == InsertMode.STRICT){
Review Comment:
I think `hasPrecombineColumn` can be removed. For COW table STRICT insert
mode, PK uniqueness should be honored irrespective of precombine field. cc
@leesf @alexeykudinkin
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
