danny0405 commented on code in PR #7295:
URL: https://github.com/apache/hudi/pull/7295#discussion_r1031127410
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/table/catalog/HoodieHiveCatalog.java:
##########
@@ -382,6 +383,8 @@ private Table translateSparkTable2Flink(ObjectPath
tablePath, Table hiveTable) {
parameters.putAll(TableOptionProperties.translateSparkTableProperties2Flink(hiveTable));
String path = hiveTable.getSd().getLocation();
parameters.put(PATH.key(), path);
+ Map<String, String> hoodieProps = loadFromHoodiePropertieFile(path,
hiveConf);
+
parameters.putAll(TableOptionProperties.translateSparkTableProperties2Flink(hoodieProps));
if
(!parameters.containsKey(FlinkOptions.HIVE_STYLE_PARTITIONING.key())) {
Review Comment:
We can read the table config through
`StreamerUtil.createMetaClient(xx).getTableConfig()`
We actually get the original hive table params first here: `parameters =
hiveTable.getParameters()`, you mean there are options missing for spark ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
